fix(UI) : Navbar Collapsing Issue #268 #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MananAgr2003
changed the title
|
please squash your commits into one |
MananAgr2003
force-pushed
the
MananAgr2003/fix/268
branch
from
48a00f1
to
e09aa85
Compare
|
@dushimsam I have squashed the PR kindly review it and merge accordingly. |
MananAgr2003
force-pushed
the
MananAgr2003/fix/268
branch
from
30cb580
to
e09aa85
Compare
|
@GMishx @shaheemazmalmmd @Shruti3004 Can you please have a look into this PR? |
Shruti3004
requested changes
Jan 23, 2023
| @@ -0,0 +1,6 @@ | |||
| @media only screen and (max-width: 550px) { | |||
| #footer { | |||
| max-width: 102vw; | |||
There was a problem hiding this comment.
making its width 102vw will make the footer overflow horizontally.
|
Hey @MananAgr2003 please remove the |
github-actions
bot
added
the
has merge conflicts
|
This pull request has conflicts, please rebase to resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issue #268 and improved the navbar in the mobile UI.
Fixed Overflow issue in mobile UI.
Relevant ScreenShots :
before :
after :