-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mobile support (WIP) #227
base: main
Are you sure you want to change the base?
feat: mobile support (WIP) #227
Conversation
Currently, I have tried to make the most of existing widgets by adding |
@DenserMeerkat Thanks for the PR. We will review it and get back. |
@DenserMeerkat You are going in the right direction. I recommend you to continue thinking about the end user and improve the UI/UX to make his life easier and the app more intuitive to use. Some feedback points:
227.header.rangeerror.mov
|
@animator Thanks for taking the time to review my implementation! I appreciate you pointing out the scrolling and focus problems in the widgets. I too noticed these and I'm already working on solutions to ensure these widgets work flawlessly with touch interactions and deliver the intended functionality. Response IconI spent some time trying to find an icon which represents API Response but couldn't find a particular one so settled with the Comment icon. Will try finding alternatives. View Code buttonInitially just had the "< >" icon in button for a clean layout and clear button hierarchy, but added "View Code" label for user's clarity of the button's function. Happy to revert based on your feedback. Will get back to you if I have any updates/doubts on fixes. |
@animator |
Yes, all three should be there. |
PR Description
Implementing the Figma Link design with maximum (almost all) available components, to discuss the design decisions.
demo.mp4
Related Issues
Checklist
flutter test
) and all tests are passingAdded/updated tests?