Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure "fortran_std=f2008" #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zoziha
Copy link
Contributor

@zoziha zoziha commented Apr 12, 2023

Almost all Fortran compilers today support the Fortran 2008 standard, and minpack uses the Fortran 2018 syntax for error stop in the pure function.
Given that some users are not using the latest version of the Fortran compiler, it seems that the best approach for now is to keep minpack to the Fortran 2008 standard.

  • Make sure to use fortran_std=f2008 in meson.build;
  • Removes unused variables and pure attributes from test routines.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #77 (186be70) into main (281e9b9) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   88.77%   88.80%   +0.02%     
==========================================
  Files           2        2              
  Lines        1221     1224       +3     
  Branches      456      456              
==========================================
+ Hits         1084     1087       +3     
  Misses         40       40              
  Partials       97       97              

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zoziha
Copy link
Contributor Author

zoziha commented Apr 26, 2023

Is there any progress?

@certik
Copy link
Member

certik commented Apr 26, 2023

@zoziha are you waiting for a review? I asked @jacobwilliams to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants