Disable whitespace disrupting CUDA chevrons #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, fprettify did not understand CUDA fortran's triple-chevron syntax for calling kernel functions, e.g. ```fortran call example_kernel<<<1, 1>>>(args) ``` As a result, each symbol in the chevrons `<<<` would have whitespace added, resulting in the incorrect syntax: ```fortran call example_kernel < < < 1, 1 > > > (args) ``` This problem only occurs when adding whitespace around relational operators is enabled. This commit adds an escape hatch to the function that handles whitespace around operators `add_whitespace_context` which disables the whitespace handling for any line that matches the REGEX "<<<.*>>>": ```python CUDA_CHEVRONS_RE = re.compile(r"<<<.*>>>", RE_FLAGS) ... if not ( ... or CUDA_CHEVRONS_RE.search(line) ): ``` This change should not break any Fortran syntax, however any relational operator that appears in a line that *also* features a triple-chevron will not be formatted, e.g. ```fortran call example_kernel<<<1, 1>>>(3< 4, var1 ==var2) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, fprettify did not understand CUDA fortran's triple-chevron syntax for calling kernel functions, e.g.
As a result, each symbol in the chevrons
<<<would have whitespace added, resulting in the incorrect syntax:This problem only occurs when adding whitespace around relational operators is enabled.
This commit adds an escape hatch to the function that handles whitespace around operators
add_whitespace_contextwhich disables the whitespace handling for any line that matches the REGEX "<<<.*>>>":This change should not break any Fortran syntax, however any relational operator that appears in a line that also features a triple-chevron will not be formatted, e.g.
This fixes #124.