Support for specifying unmapped area #485
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vn971
reviewed
Aug 29, 2023
| .validator(u64::validate_arg) | ||
| .required(false) | ||
| .default_value("0") | ||
| .help("Specify the (minimum) size of unmapped memory (useable on SGXv2 capable processors only)"), |
There was a problem hiding this comment.
I wonder, should we clarify why a user would be interested in this option? E.g.
Specifying an unmapped memory size allows dynamically allocating additional heap space on SGXv2 capable processors
I understand on the other hand that maybe we don't want to advertise it if the whole feature set is not ready yet; not sure.
What do you think?
Looks good to me either way 👍
There was a problem hiding this comment.
Maybe we should even call it dynamic memory or something.
There was a problem hiding this comment.
Good point about not adding it to master yet. Will mark the PR as draft again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGXv2 supports dynamically adding memory. This initial PR addresses issue #482 and adds support to the
ftxsgx-elf2sgxstool to reserve unmapped memory within the enclave.Fixes #482