This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Minor changes #189
Open
Minor changes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the test logs it seems that some templates are missing. Is that correct? |
|
Think it has something to do with how the tests run I'll investigate further |
|
@fiatjaf I believe I did everything to switch over from raw id's to the hash, but please see if you spot anything else I missed, otherwise I think this is done |
|
Why can't we expose the ids and hide the hashids? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Have you made sure to add:
Any Additional Information
Not sure if I've gotten all the email templates, but I believe I have?