Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-7307 Fixed 'Everyone' role export/import #1638

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

antonSoftensity
Copy link
Contributor

@antonSoftensity antonSoftensity commented Sep 25, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-7307

Description

Previously, 'Everyone' role wasn't included in export file because it doesn't exist in database, and the only roles that were exported were the roles from the db. I've added a code that forcefully adds 'Everyone' role to an array of roles when exporting, but doesn't add it to the 'roles' object. That way it is not added to the database when the project template gets imported, but at the same time the server can convert 'everyone' role to the ID and back.

Dependencies

https://github.com/formio/formio-server/pull/1358

How has this PR been tested?

Tested locally

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants