Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Missing nunjucks dependency and make formio compatible with current versions of mongo #1578

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TriStarGod
Copy link

@TriStarGod TriStarGod commented Jun 7, 2023

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-XXXX
Refer to ticket #1575

Description

What changed?
Nunjucks dependency is missing from formio's package.json
mongo url using localhost may fail with current versions of mongo unless its replaced with 127.0.0.1

Previously, formio ... This PR replaces this behavior by ...

Why have you chosen this solution?
Proper package.json setup and now pnpm compatible
Backwards and future compatible with mongo

Although there were many potential solutions such as ..., [my solution] was best because ...
All changes are backwards compatible

Dependencies

This PR depends on the following PRs from other Form.io modules: ...

How has this PR been tested?

I added automated tests to cover [all/the following] cases, including ...
An automated test with a better package manager like pnpm might be useful

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant