Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIO-8281: fixed selectData property for multiple select component #5592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roma-formio
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8281

Description

Fixed the issue regarding setting selectData property for the multiple select component.

Dependencies

formio/core#93

How has this PR been tested?

Unit testing

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your new tests are failing

@roma-formio
Copy link
Contributor Author

It looks like your new tests are failing

Yes, they're failing because my changes depend on @formio/core validation changes for the URL Select Component. In the current version it's impossible to create the multiple URL select component with default value and my test is trying to do this.

@brendanbond
Copy link
Contributor

It looks like your new tests are failing

Yes, they're failing because my changes depend on @formio/core validation changes for the URL Select Component. In the current version it's impossible to create the multiple URL select component with default value and my test is trying to do this.

Gotcha. FYI we've just introduced a CICD system that's pretty cool - your @formio/core PR automatically built and published a dev-tagged version of the core lib to NPM (2.0.0-dev.93.5a2c62c) so we can now update these dependencies in our PRs to make sure tests are passing! I've gone ahead and pushed an update to this PR to update the version of @formio/core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants