Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvc5 mappings #106

Merged
merged 7 commits into from May 24, 2024
Merged

cvc5 mappings #106

merged 7 commits into from May 24, 2024

Conversation

joaomhmpereira
Copy link
Member

Addition of mappings for the cvc5 solver

@joaomhmpereira joaomhmpereira added the enhancement New feature or request label Apr 15, 2024
@joaomhmpereira joaomhmpereira marked this pull request as ready for review April 28, 2024 17:17
@joaomhmpereira joaomhmpereira marked this pull request as draft April 28, 2024 17:18
@joaomhmpereira joaomhmpereira marked this pull request as ready for review May 20, 2024 13:26
Copy link
Member

@filipeom filipeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd prefer we used better names for the string functions. I left some suggestions below.

lib/mappings_intf.ml Outdated Show resolved Hide resolved
lib/mappings_intf.ml Outdated Show resolved Hide resolved
@filipeom
Copy link
Member

Thanks! I'm fine with merging this if you think it has everything you need :)

@joaomhmpereira joaomhmpereira merged commit ebc0edf into main May 24, 2024
4 checks passed
@joaomhmpereira joaomhmpereira deleted the cvc5_mappings branch May 24, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants