[Theme] Inverted social icons in night theme #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
approved these changes
Mar 26, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Inverted the social icons in the sidebar so they will be more visible when using night theme. Inverting them will remove the need to provide icons in a different colour.
I know
filter: var(--theme-social-icon-invert, invert(0));looks ugly, I tried it this way first:filter: invert(var(--theme-social-icon-invert, 0));but it kept giving me a SASS error.I think it is related to this issue: sass/libsass#151 but it was fixed this this PR: sass/libsass#515
Any suggestions are welcome to clean it up.
Related Tickets & Documents
/
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Before
After
Added to documentation?