Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove monetization (users payment pointers) #20963

Merged
merged 3 commits into from
May 21, 2024

Conversation

lightalloy
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Optimization

Description

First step to remove monetization:

Removed:

  • updating payment pointer in user settings
  • rendering payment pointer on users articles, comments, profile

Haven't touched:

  • users payment pointer fields in the db
  • users payment pointers validation in the User model
  • admin monetization settings in /admin/settings
  • rendering Settings::General.payment_pointer through the site

Should general monetization settings be fully removed as well? ( Settings::General.payment_pointer) (I suppose yes).
There are also stipe keys in the monetization block, should they be removed or are they used anywhere else?

Related Tickets & Documents

@lightalloy lightalloy requested review from a team as code owners May 18, 2024 11:47
Copy link
Contributor

github-actions bot commented May 18, 2024

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20963

⚙️ Updating now by workflow run 9170816146.

What is Uffizzi? Learn more!

@lightalloy
Copy link
Contributor Author

admin/badges_spec.rb is failing when run after a system test, e.g.

bundle exec rspec "spec/system/comments/user_edits_a_comment_spec.rb"  "spec/requests/admin/badges_spec.rb"

Edge caching is set and not cleared after a system test, so current_user remains "You may not access ..." 🌚

@benhalpern benhalpern merged commit 0c11abe into main May 21, 2024
32 checks passed
@benhalpern benhalpern deleted the lightalloy/remove-monetization branch May 21, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants