Add basic browser/device targeting to billboards #20680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
app/models/billboard.rb
Outdated
| @@ -79,7 +80,7 @@ class Billboard < ApplicationRecord | |||
|
|
|||
| self.table_name = "display_ads" | |||
|
|
|||
| def self.for_display(area:, user_signed_in:, user_id: nil, article: nil, user_tags: nil, location: nil, cookies_allowed: false) | |||
| def self.for_display(area:, user_signed_in:, user_id: nil, article: nil, user_tags: nil, location: nil, cookies_allowed: false, user_agent: nil) | |||
There was a problem hiding this comment.
📝 [rubocop] <Layout/LineLength> reported by reviewdog 🐶
Line is too long. [146/120] (https://rubystyle.guide#max-line-length)
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20680 ⚙️ Updating now by workflow run 8055656740. What is Uffizzi? Learn more! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Allow billboards to target a browser context (i.e. desktop browser, mobile browser, in-app browser). We could add other specific targeting to the list in the future (i.e. tablet, etc. IOS/Android, Mac/Windows) if we have that need, but keeping it to simple use cases for now.
Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included