Beta release workflow #113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fdocr
commented
Nov 16, 2020
| echo "This will fail because we don't have the secrets configured yet" | ||
| echo "$ANDROID_KEYSTORE_FILE" > keystore.jks.b64 | ||
| base64 -d -i keystore.jks.b64 > app/keystore.jks | ||
| echo "storeFile=keystore.jks" >> keystore.properties |
There was a problem hiding this comment.
The workflow from which this was based on (here) creates the keystore.properties manually, but we can just base64 encode it whole instead if that feels cleaner. In that case we can replace KEYSTORE_KEY_ALIAS, KEYSTORE_KEY_PASSWORD and KEYSTORE_STORE_PASSWORD for a single secret. I don't feel strongly about either approach
There was a problem hiding this comment.
We should keep it separate. it will be easier to update
…fdoxyz/beta-release-workflow
maestromac
reviewed
Nov 18, 2020
|
@maestromac yeah, until we can find a way to work around this I'm making this a Draft 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds CD to our pipeline for a more streamlined release process
Related Tickets & Documents
#81
[optional] What gif best describes this PR or how it makes you feel?