fix: add oauth options data to auth code exchange errors #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
May 14, 2024
src/org/authInfo.ts
Outdated
| @@ -1242,6 +1257,21 @@ export class AuthInfo extends AsyncOptionalCreatable<AuthInfo.Options> { | |||
| } | |||
| } | |||
|
|
|||
| const getRedactedErrData = (options: JwtOAuth2Config): AnyJson => { | |||
There was a problem hiding this comment.
check out
sfdx-core/src/logger/filters.ts
Line 71 in 2526e34
since it's a function and not bound up inside Logger, it might be useful here.
And if it's not handling something well (ex: authCode) then we could add that and it'll automatically make Logger better.
src/org/authInfo.ts
Outdated
| error = SfError.wrap(err); | ||
| errorMsg = error.message; | ||
| } | ||
| error.message = messages.getMessage('authCodeExchangeError', [errorMsg]); |
There was a problem hiding this comment.
this would overwrite the message set from 1114?
There was a problem hiding this comment.
Kind of. I want the server's error name and error description to be part of the authCode exchange error message.
mshanemc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds oauth options data to auth code exchange errors, redacting sensitive information, to improve telemetry.
What issues does this PR fix or reference?
@W-15758926@