fix: add a method that returns a 04t from a partial package descriptor entry #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
May 17, 2024
| * or a package Id (0Ho) + a version number. Additionally, a build number may be the actual build number, or a | ||
| * keyword: LATEST or RELEASED (meaning the latest or released build number for a given major.minor.patch). | ||
| * | ||
| * This method resolves a package Id + version number to a subscriber package version id (04t) | ||
| * and adds it as a SubscriberPackageVersionId parameter in the dependency object. | ||
| */ | ||
| private async retrieveSubscriberPackageVersionId(dependency: PackageDescriptorJson): Promise<PackageDescriptorJson> { | ||
| await this.validateDependencyValues(dependency); | ||
| if (dependency.subscriberPackageVersionId) { |
There was a problem hiding this comment.
do we need to call resolveSubscriberPackageVersionId here now since we moved this into its own method?
WillieRuemmele
deleted the
sh/make-retrieveSubscriberPackageVersionId-public
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a public static method to the
SubscriberPackageVersionAPI that returns the SubscriberPackageVersionId (04t) given a partial packageDirectories entry (versionNumberandpackageIdfields, as well as an optionalbranchfield).forcedotcom/cli#2721
@W-15611712@