Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progress): basic variant and support empty bar #3040

Merged
merged 3 commits into from May 13, 2024
Merged

feat(progress): basic variant and support empty bar #3040

merged 3 commits into from May 13, 2024

Conversation

lubber-de
Copy link
Member

Description

  • Added new basic variant for progress, which removes the remaining bar background
  • Supported a proper minimum bar width when it does not contain any content

Testcase

Remove CSS to see difference
https://jsfiddle.net/lubber/1f0jtgq8/14/

Screenshots

Before

  • First progressbars as usual
  • Last progress bar should have a proper width of 1%, but still shows a wider width because this is occupied for a possible text of "1%"
    image

After

  • first two dont show remaining bar background anymore as expected for the new "basic" variant
  • 1% width as expected
    image

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Apr 30, 2024
@lubber-de lubber-de added this to the 2.9.4 milestone Apr 30, 2024
@lubber-de lubber-de mentioned this pull request May 11, 2024
Merged
@lubber-de
Copy link
Member Author

Docs added by fomantic/Fomantic-UI-Docs#503

@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels May 11, 2024
prudho
prudho approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lubber-de lubber-de merged commit 4c35b29 into fomantic:develop May 13, 2024
10 checks passed
@lubber-de lubber-de deleted the basicProgress branch May 13, 2024 10:47
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label May 13, 2024
lubber-de added a commit to fomantic/Fomantic-UI-Docs that referenced this pull request May 13, 2024
@lubber-de
feat(progress): basic progress example
ce6882b 
basic variant example as of fomantic/Fomantic-UI#3040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prudho prudho prudho approved these changes

@ko2in ko2in Awaiting requested review from ko2in

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lubber-de @prudho