Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(day)!: Chose palette for day #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gi1242
Copy link

@gi1242 gi1242 commented Feb 6, 2024

Thanks for creating this color scheme. I recently started using treesitter and found this colorscheme very helpful.

I did, however, find the day colors washed out. I like having a bright background (#ffffff) during the day; to do this I have to set day_brightness = 0, and in that case the colors are all washed out and too similar. Looking at the code, it looks like in day mode you just invert colors of the night palette and then increase the lightness if it is too dark. I couldn't find a clean elegant way to fix it so that foreground colors stay dark but are more vibrant.

Instead, I just manually inverted the colors and played with the saturation / lightness so that it was vibrant enough. With a manually chosen palette the day_brightness setting isn't needed anymore, so I removed it. (Technically the invert_colors and invert_highlights functions aren't needed either.)

Feel free to merge this if you like it.

Personally I use

fg=#000000
terminal_black=#000000
bg=#ffffff

but I let the defaults be softer colors obtained by inverting the night palette.

BREAKING CHANGE: removed day_brightness, as it's not needed anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant