fix(day)!: Chose palette for day #492
Open
+39
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for creating this color scheme. I recently started using treesitter and found this colorscheme very helpful.
I did, however, find the day colors washed out. I like having a bright background (#ffffff) during the day; to do this I have to set
day_brightness = 0
, and in that case the colors are all washed out and too similar. Looking at the code, it looks like in day mode you just invert colors of the night palette and then increase the lightness if it is too dark. I couldn't find a clean elegant way to fix it so that foreground colors stay dark but are more vibrant.Instead, I just manually inverted the colors and played with the saturation / lightness so that it was vibrant enough. With a manually chosen palette the
day_brightness
setting isn't needed anymore, so I removed it. (Technically theinvert_colors
andinvert_highlights
functions aren't needed either.)Feel free to merge this if you like it.
Personally I use
but I let the defaults be softer colors obtained by inverting the night palette.