Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error if lspconfig is not installed #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrcjkb
Copy link

@mrcjkb mrcjkb commented Feb 19, 2024

I don't use lspconfig, but I currently use neoconf to tell neodev which plugins to load include in the lua-language-server's workspace.library (with lspconfig = false).

Since i removed lspconfig from my plugins, neoconf errors because it expects it to be installed.
This PR adds some checks to prevent that from happening.

I'm not sure if neoconf is useful without lspconfig (neodev is still adding the neovim lua API, but it doesn't seem to pick up the plugin lists in neoconf.json anymore).

@bugabinga
Copy link

I am in the same boat. Not using lspconfig, but would love to have neoconf overriding local lsp settings.

Can we reimplement the functions in util.lua, that depend on lspconfig to be independent?

@mrcjkb
Copy link
Author

mrcjkb commented Mar 19, 2024

I am in the same boat. Not using lspconfig, but would love to have neoconf overriding local lsp settings.

Can we reimplement the functions in util.lua, that depend on lspconfig to be independent?

I have stopped using neoconf, so that would probably have to be done by someone else in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants