feat: allow root_dir conflict resolution in config #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeLagrange
force-pushed
the
feat/allow-root-dir-conflict-resolution
branch
from
aeb9bee
to
3e545e1
Compare
GuillaumeLagrange
force-pushed
the
feat/allow-root-dir-conflict-resolution
branch
from
3e545e1
to
7f90b0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thank you for the plugin which is working wonderfully well and solves an immense pain of working with nvim in a vs code world.
While working in a Rust monorepo, my workspace root_dir is set to
${REPO_ROOT}/.cargo/workspace, while the root dir for some crates is${REPO_ROOT}/path/to/crate.If the
path/to/crateis shorter than.cargo/workspace, neoconf resolves the root dir as.cargo/workspacesince it is longer. This is not a desired behavior on my end, since the monorepo is very large and rust-analyzer commes with insane behavior on startup for large code base.This PR aims to make the conflict resolution performed in
neoconf/util.lua.Don't hesitate to tear the code a new one, this is my first lua PR, and I find the code in this plugin quite complex 馃槄
Cheers