Skip to content

Commit

Permalink
STRIPES-678 pin moment to ~2.24
Browse files Browse the repository at this point in the history
Pin `moment` at `~2.24.0` in light of multiple issues with `2.25.0`
([5489](moment/moment#5489), [5472](moment/moment#5472)).

The `resolutions` entry is necessary because `2.25` leaks in via
transitive deps. I don't know why it is necessary here when it isn't,
say, in ui-circulation, which pulls it in via the same route of
stripes-cli and stripes-core. That makes no sense. Alas.

Refs [STRIPES-678](https://issues.folio.org/browse/STRIPES-678)
  • Loading branch information
zburke committed May 4, 2020
1 parent 7fb07a1 commit c33a5fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -22,6 +22,7 @@
* Pass current `servicePointId` to `declare-item-lost`. Part of UIU-1203.
* Preserve filters after user is edited. Fixes UIU-1604.
* Remove hardcoded ids from Parton Block Conditions page. Refs UIU-1609.
* Pin `moment` at `~2.24.0`. Refs STRIPES-678.

## [3.0.0](https://github.com/folio-org/ui-users/tree/v3.0.0) (2020-03-17)
[Full Changelog](https://github.com/folio-org/ui-users/compare/v2.26.0...v3.0.0)
Expand Down
5 changes: 4 additions & 1 deletion package.json
Expand Up @@ -780,7 +780,7 @@
"@folio/stripes-util": "^2.0.0",
"hashcode": "^1.0.3",
"lodash": "^4.17.4",
"moment": "^2.22.2",
"moment": "~2.24.0",
"prop-types": "^15.5.10",
"query-string": "^5.0.0",
"react-hot-loader": "^4.3.12",
Expand All @@ -798,5 +798,8 @@
},
"optionalDependencies": {
"@folio/plugin-find-user": "^2.0.0"
},
"resolutions": {
"moment": "~2.24.0"
}
}

0 comments on commit c33a5fb

Please sign in to comment.