Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UIIN-2793: Populate Acquisitions accordion on instance when central ordering is active #2482

Merged
merged 16 commits into from May 15, 2024
Merged

UIIN-2793: Populate Acquisitions accordion on instance when central ordering is active #2482

merged 16 commits into from May 15, 2024

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented May 10, 2024 •
edited

Purpose

  • Display Instance acquisitions for non-central (active) and central tenant.

Approach

  • If user is on non-consortial tenant or on central tenant - display only the list of instance acquisitions.
  • If user is on non-central tenant - display sub accordion with the list of instance acquisitions for active and central tenant.
  • Created TenantAcquisition component that is responsible only for rendering the list of instance acquisitions.
  • Created and updated unit tests.

Refs

UIIN-2793

Screenshots

Non-central tenant

image

Central tenant

image

Non-consortial tenant

image

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited

Jest Unit Test Statistics

       1 files  ±0     249 suites  +1   12m 54s ⏱️ -1s
1 012 tests +3  1 010 ✔️ +3  2 💤 ±0  0 ❌ ±0 
1 018 runs  +3  1 016 ✔️ +3  2 💤 ±0  0 ❌ ±0 

Results for commit 07758f5. ± Comparison against base commit e0bc47e.

♻️ This comment has been updated with latest results.

@OleksandrHladchenko1 OleksandrHladchenko1 marked this pull request as draft May 10, 2024 14:04
@OleksandrHladchenko1 OleksandrHladchenko1 marked this pull request as ready for review May 13, 2024 13:54
@OleksandrHladchenko1 OleksandrHladchenko1 requested a review from a team May 13, 2024 13:54
@Terala-Priyanka Terala-Priyanka requested a review from a team May 14, 2024 07:16
Terala-Priyanka
Terala-Priyanka requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failed unit tests.

Dmytro-Melnyshyn
Dmytro-Melnyshyn reviewed May 14, 2024
View reviewed changes
src/constants.js Outdated Show resolved Hide resolved
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team May 14, 2024 13:34
@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team May 14, 2024 14:47
BogdanDenis
BogdanDenis approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@BogdanDenis BogdanDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry as well

zburke
zburke approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. Please fix the typo in constants.js.

src/Instance/InstanceDetails/InstanceAcquisition/InstanceAcquisition.js Show resolved Hide resolved
src/constants.js Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 6aa7b8b into master May 15, 2024
5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-2793 branch May 15, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zburke zburke zburke approved these changes

@BogdanDenis BogdanDenis BogdanDenis approved these changes

@Dmytro-Melnyshyn Dmytro-Melnyshyn Dmytro-Melnyshyn approved these changes

@Terala-Priyanka Terala-Priyanka Awaiting requested review from Terala-Priyanka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@OleksandrHladchenko1 @zburke @BogdanDenis @Dmytro-Melnyshyn @Terala-Priyanka