UIIN-2896 Inventory app: Define and implement shortcut key for editing a quickMARC bib record #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g a quickMARC bib record
| const searchParams = new URLSearchParams(location.search); | ||
|
|
||
| searchParams.delete('relatedRecordVersion'); | ||
| searchParams.append('shared', instance.shared?.toString()); |
There was a problem hiding this comment.
This is the second place we push shared to URL. It might be worth to make a separate function for this.
I think that if we open a locally shared record using the shortcut, we will push shared value to false. If we are going to fix that behavior like
const isInstanceShared = Boolean(isShared || isInstanceShadowCopy(instance?.source));
then it would be nice to do it in just one place.
| }); | ||
| }, [isHoldingsRecord]); | ||
|
|
||
| const shortcuts = useMemo(() => [ |
There was a problem hiding this comment.
Please add a second argument to useMemo.
Dmytro-Melnyshyn
approved these changes
May 14, 2024
UladzislauKutarkin
approved these changes
May 20, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new
Ctrl+Shift+Eshortcut to open Instance/Holdings records in quickMARC editorScreenshots
chrome_TSlvM67oiK.mp4
Issues
UIIN-2896