UIIN-2668: Jest/RTL: Cover InstancePlugin component with unit tests #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-blazhko
requested changes
Apr 26, 2024
| jest.clearAllMocks(); | ||
| }); | ||
|
|
||
| it('should InstancePlugin', () => { |
There was a problem hiding this comment.
What does it mean 'should InstancePlugin'?
Maybe you meant something like 'should render InstancePlugin'?
| }); | ||
|
|
||
| it('should InstancePlugin', () => { | ||
| renderWithIntl(<InstancePlugin onSelectMock={onSelectMock} isDisabled={false} />); |
There was a problem hiding this comment.
I think onSelectMock property is not expected.
Maybe you meant
Suggested change
| renderWithIntl(<InstancePlugin onSelectMock={onSelectMock} isDisabled={false} />); | |
| renderWithIntl(<InstancePlugin onSelect={onSelectMock} isDisabled={false} />); |
There was a problem hiding this comment.
Hi @artem-blazhko, fixed
vashjs
approved these changes
Apr 26, 2024
|
artem-blazhko
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/UIIN-2668
We added tests for
InstancePlugin