Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace moment with dayjs #1706

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

replace moment with dayjs #1706

wants to merge 6 commits into from

Conversation

JohnC-80
Copy link
Contributor

@JohnC-80 JohnC-80 commented Jan 5, 2024

The moment project has been sunset for a bit now.
In efforts to move the FOLIO platform to a supported library with as easy a transition as possible. we intend to make the move to dayJS.
It's practically a drop-in replacement for moment, with a VERY similar API.

Its locale information is split from the main bundle and it's very modular/plugin-based.
stripes-components will re-export/provide the import for dayjs with numerous useful plugins included as well as utilities for dynamically loading dayjs locale data.

More information is available at https://day.js.org/en/

Related PR's:

Copy link

github-actions bot commented Jan 5, 2024

Jest Unit Test Statistics

       1 files  ±0     193 suites  ±0   8m 8s ⏱️ -6s
1 090 tests ±0     993 ✔️  - 30  2 💤 ±0  95 +30 
1 098 runs  ±0  1 000 ✔️  - 31  2 💤 ±0  96 +31 

For more details on these failures, see this check.

Results for commit f80e13a. ± Comparison against base commit 6578b6b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BogdanDenis BogdanDenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JohnC-80, the PR looks good. I've added one commit to fix some import formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants