Poppy

.eslintrc

@@ -12,9 +12,10 @@
   },
   "plugins": ["cypress", "import"],
   "rules": {
+    "no-unused-vars": "error",
     "cypress/no-assigning-return-values": "error",
     "cypress/assertion-before-screenshot": "warn",
     "cypress/no-force": "warn",
-    "cypress/no-async-tests": "error"
+    "no-duplicate-imports": "error"
   }
 }

.github/workflows/build-npm.yml

@@ -65,7 +65,6 @@ jobs:
 
       - name: Run yarn lint
         run: yarn lint
-        continue-on-error: true
 
       - name: Run yarn test
         run: xvfb-run --server-args="-screen 0 1024x768x24" yarn test $YARN_TEST_OPTIONS

.gitignore

@@ -13,4 +13,5 @@ cypress/screenshots
 
 allure-results
 
-videos
+videos
+.vs

cypress.config.js

@@ -1,8 +1,9 @@
 const { defineConfig } = require('cypress');
 const path = require('path');
 const globby = require('globby');
-const { rmdir, unlink } = require('fs');
+const csvToJson = require('convert-csv-to-json');
 const { downloadFile } = require('cypress-downloadfile/lib/addPlugin');
+const { rmdir, unlink } = require('fs');
 const fs = require('fs');
 const allureWriter = require('@shelex/cypress-allure-plugin/writer');
 const { cloudPlugin } = require('cypress-cloud/plugin');
@@ -18,13 +19,14 @@ module.exports = defineConfig({
   video: false,
   defaultCommandTimeout: 101000,
   pageLoadTimeout: 120000,
+  downloadsFolder: 'cypress/downloads',
   env: {
     OKAPI_HOST: 'https://okapi-bugfest-poppy-aqa.int.aws.folio.org',
     OKAPI_TENANT: 'fs09000003',
     diku_login: 'folio-aqa',
     diku_password: 'Folio-aqa1',
     is_kiwi_release: false,
-    downloadTimeout: 1000,
+    downloadTimeout: 2000,
     allure: 'true',
     grepFilterSpecs: true,
     grepOmitFiltered: true,
@@ -35,6 +37,12 @@ module.exports = defineConfig({
       allureWriter(on, config);
 
       on('task', {
+        log(message) {
+          // eslint-disable-next-line no-console
+          console.log(message);
+          return null;
+        },
+
         async findFiles(mask) {
           if (!mask) {
             throw new Error('Missing a file mask to search');
@@ -48,6 +56,11 @@ module.exports = defineConfig({
 
           return list;
         },
+
+        convertCsvToJson(fileName) {
+          return csvToJson.supportQuotedField(true).fieldDelimiter(',').getJsonFromCsv(fileName);
+        },
+
         downloadFile,
 
         deleteFolder(folderName) {
@@ -92,7 +105,10 @@ module.exports = defineConfig({
       const configCloud = await cloudPlugin(on, config);
 
       // eslint-disable-next-line global-require
-      const result = await require('cypress-testrail-simple/src/plugin')(on, configCloud);
+      const result = require('@cypress/grep/src/plugin')(configCloud);
+
+      // eslint-disable-next-line global-require
+      await require('cypress-testrail-simple/src/plugin')(on, config);
 
       return result;
     },

cypress/e2e/acquisition-units/acquisition-unit-restrictions-for-FY-when-user-assigned-to-AU.cy.js

@@ -1,14 +1,12 @@
 import permissions from '../../support/dictionary/permissions';
-import testType from '../../support/dictionary/testTypes';
-import devTeams from '../../support/dictionary/devTeams';
-import getRandomPostfix from '../../support/utils/stringTools';
-import DateTools from '../../support/utils/dateTools';
-import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
-import TopMenu from '../../support/fragments/topMenu';
 import FinanceHelp from '../../support/fragments/finance/financeHelper';
-import SettingsMenu from '../../support/fragments/settingsMenu';
+import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
 import AcquisitionUnits from '../../support/fragments/settings/acquisitionUnits/acquisitionUnits';
+import SettingsMenu from '../../support/fragments/settingsMenu';
+import TopMenu from '../../support/fragments/topMenu';
 import Users from '../../support/fragments/users/users';
+import DateTools from '../../support/utils/dateTools';
+import getRandomPostfix from '../../support/utils/stringTools';
 
 describe('Acquisition Units', () => {
   const defaultAcquisitionUnit = { ...AcquisitionUnits.defaultAcquisitionUnit };
@@ -87,7 +85,7 @@ describe('Acquisition Units', () => {
 
   it(
     'C374168 Acquisition unit restrictions for "Fiscal year" records (View, Edit, Create, Delete options are active) when user is assigned to acquisition unit (thunderjet)',
-    { tags: [testType.criticalPath, devTeams.thunderjet] },
+    { tags: ['criticalPath', 'thunderjet'] },
     () => {
       FinanceHelp.searchByAll(firstFiscalYear.name);
       FiscalYears.selectFisacalYear(firstFiscalYear.name);

cypress/e2e/acquisition-units/acquisition-unit-restrictions-for-FY-when-user-is-NOT-assigned-to-AU-only-edit-and-view.cy.js

@@ -1,11 +1,9 @@
 import permissions from '../../support/dictionary/permissions';
-import testType from '../../support/dictionary/testTypes';
-import devTeams from '../../support/dictionary/devTeams';
-import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
-import TopMenu from '../../support/fragments/topMenu';
 import FinanceHelp from '../../support/fragments/finance/financeHelper';
-import SettingsMenu from '../../support/fragments/settingsMenu';
+import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
 import AcquisitionUnits from '../../support/fragments/settings/acquisitionUnits/acquisitionUnits';
+import SettingsMenu from '../../support/fragments/settingsMenu';
+import TopMenu from '../../support/fragments/topMenu';
 import Users from '../../support/fragments/users/users';
 
 describe('Acquisition Units', () => {
@@ -85,7 +83,7 @@ describe('Acquisition Units', () => {
 
   it(
     'C375079 Acquisition unit restrictions for "Fiscal year" records (Create, Delete options are active) when user is NOT assigned to acquisition unit (thunderjet)',
-    { tags: [testType.criticalPath, devTeams.thunderjet] },
+    { tags: ['criticalPath', 'thunderjet'] },
     () => {
       FinanceHelp.searchByAll(defaultFiscalYear.name);
       FiscalYears.selectFisacalYear(defaultFiscalYear.name);

cypress/e2e/acquisition-units/acquisition-unit-restrictions-for-FY-when-user-is-NOT-assigned-to-AU-only-view.cy.js

@@ -1,11 +1,9 @@
 import permissions from '../../support/dictionary/permissions';
-import testType from '../../support/dictionary/testTypes';
-import devTeams from '../../support/dictionary/devTeams';
-import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
-import TopMenu from '../../support/fragments/topMenu';
 import FinanceHelp from '../../support/fragments/finance/financeHelper';
-import SettingsMenu from '../../support/fragments/settingsMenu';
+import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
 import AcquisitionUnits from '../../support/fragments/settings/acquisitionUnits/acquisitionUnits';
+import SettingsMenu from '../../support/fragments/settingsMenu';
+import TopMenu from '../../support/fragments/topMenu';
 import Users from '../../support/fragments/users/users';
 
 describe('Acquisition Units', () => {
@@ -83,7 +81,7 @@ describe('Acquisition Units', () => {
 
   it(
     'C375078 Acquisition unit restrictions for "Fiscal year" records (Edit, Create, Delete options are active) when user is NOT assigned to acquisition unit (thunderjet)',
-    { tags: [testType.criticalPath, devTeams.thunderjet] },
+    { tags: ['criticalPath', 'thunderjet'] },
     () => {
       FinanceHelp.searchByAll(defaultFiscalYear.name);
       FiscalYears.selectFisacalYear(defaultFiscalYear.name);

cypress/e2e/acquisition-units/acquisition-unit-restrictions-for-FY-when-user-is-NOT-assigned-to-AU.cy.js

@@ -1,11 +1,9 @@
 import permissions from '../../support/dictionary/permissions';
-import testType from '../../support/dictionary/testTypes';
-import devTeams from '../../support/dictionary/devTeams';
-import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
-import TopMenu from '../../support/fragments/topMenu';
 import FinanceHelp from '../../support/fragments/finance/financeHelper';
-import SettingsMenu from '../../support/fragments/settingsMenu';
+import FiscalYears from '../../support/fragments/finance/fiscalYears/fiscalYears';
 import AcquisitionUnits from '../../support/fragments/settings/acquisitionUnits/acquisitionUnits';
+import SettingsMenu from '../../support/fragments/settingsMenu';
+import TopMenu from '../../support/fragments/topMenu';
 import Users from '../../support/fragments/users/users';
 
 describe('Acquisition Units', () => {
@@ -80,8 +78,8 @@ describe('Acquisition Units', () => {
   });
 
   it(
-    'C375073 Acquisition unit restrictions for "Fiscal year" records (View, Edit, Create, Delete options are restricted) when user is NOT assigned to acquisition unit (thunderjet)',
-    { tags: [testType.criticalPath, devTeams.thunderjet] },
+    'C375073 Acquisition unit restrictions for "Fiscal year" records (Edit, Create, Delete options are active) when user is NOT assigned to acquisition unit (thunderjet)',
+    { tags: ['criticalPath', 'thunderjet'] },
     () => {
       FinanceHelp.searchByAll(defaultFiscalYear.name);
       FiscalYears.checkNoResultsMessage(

cypress/e2e/agreements/agreement-internal-contacts/assign-library-staff-member-to-agreement.cy.js

@@ -1,11 +1,10 @@
-import Agreements from '../../../support/fragments/agreements/agreements';
-import TopMenu from '../../../support/fragments/topMenu';
 import AgreementViewDetails from '../../../support/fragments/agreements/agreementViewDetails';
+import Agreements from '../../../support/fragments/agreements/agreements';
 import EditAgreement from '../../../support/fragments/agreements/editAgreement';
-import Users from '../../../support/fragments/users/users';
+import TopMenu from '../../../support/fragments/topMenu';
 import SelectUser from '../../../support/fragments/users/modal/selectUser';
+import Users from '../../../support/fragments/users/users';
 import { randomFourDigitNumber } from '../../../support/utils/stringTools';
-import { TestTypes, DevTeams } from '../../../support/dictionary';
 
 let agreementId;
 const firstUser = {
@@ -64,7 +63,7 @@ describe('Agreement Internal Contacts', () => {
 
   it(
     'C1314 Assign a library staff member to an Agreement (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
+    { tags: ['extendedPath', 'erm'] },
     () => {
       AgreementViewDetails.agreementListClick(Agreements.defaultAgreement.name);
       AgreementViewDetails.gotoEdit();

cypress/e2e/agreements/agreement-internal-contacts/filter-agreements-by-library-staff-member-assigned.cy.js

@@ -1,10 +1,9 @@
 import { including } from '@interactors/html';
 import Agreements from '../../../support/fragments/agreements/agreements';
+import SearchAndFilterAgreements from '../../../support/fragments/agreements/searchAndFilterAgreements';
 import TopMenu from '../../../support/fragments/topMenu';
 import Users from '../../../support/fragments/users/users';
 import { randomFourDigitNumber } from '../../../support/utils/stringTools';
-import { TestTypes, DevTeams } from '../../../support/dictionary';
-import SearchAndFilterAgreements from '../../../support/fragments/agreements/searchAndFilterAgreements';
 
 let agreement;
 let agreementId;
@@ -48,7 +47,7 @@ describe('Agreement Internal Contacts', () => {
 
   it(
     'C3460 Filter agreements by library staff member assigned (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
+    { tags: ['extendedPath', 'erm'] },
     () => {
       SearchAndFilterAgreements.openInternalContactsFilter();
       SearchAndFilterAgreements.clickSelectInternalContactButton();

cypress/e2e/agreements/agreement-lines/add-agreement-line-with-description-only.cy.js

@@ -1,10 +1,9 @@
-import Agreements from '../../../support/fragments/agreements/agreements';
-import TopMenu from '../../../support/fragments/topMenu';
-import { TestTypes, DevTeams } from '../../../support/dictionary';
+import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
 import AgreementLines from '../../../support/fragments/agreements/agreementLines';
 import AgreementViewDetails from '../../../support/fragments/agreements/agreementViewDetails';
+import Agreements from '../../../support/fragments/agreements/agreements';
 import NewAgreementLine from '../../../support/fragments/agreements/newAgreementLine';
-import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
+import TopMenu from '../../../support/fragments/topMenu';
 import { randomFourDigitNumber } from '../../../support/utils/stringTools';
 
 let agreementId;
@@ -32,7 +31,7 @@ describe('Agreement Lines', () => {
 
   it(
     'C15829 Add agreement line with description only (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
+    { tags: ['extendedPath', 'erm'] },
     () => {
       AgreementViewDetails.agreementListClick(Agreements.defaultAgreement.name);
       AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(

cypress/e2e/agreements/agreement-lines/add-tags-to-agreement-line-record.cy.js

@@ -1,9 +1,8 @@
-import Agreements from '../../../support/fragments/agreements/agreements';
-import TopMenu from '../../../support/fragments/topMenu';
-import { TestTypes, DevTeams } from '../../../support/dictionary';
+import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
 import AgreementLines from '../../../support/fragments/agreements/agreementLines';
 import AgreementViewDetails from '../../../support/fragments/agreements/agreementViewDetails';
-import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
+import Agreements from '../../../support/fragments/agreements/agreements';
+import TopMenu from '../../../support/fragments/topMenu';
 
 let agreementLine;
 let agreementId;
@@ -36,7 +35,7 @@ describe('Agreement Lines', () => {
 
   it(
     'C343340 Add tags to an Agreement Line record (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
+    { tags: ['extendedPath', 'erm'] },
     () => {
       AgreementViewDetails.agreementListClick(Agreements.defaultAgreement.name);
       AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(

cypress/e2e/agreements/agreement-lines/delete-agreement-line.cy.js

@@ -1,11 +1,10 @@
-import Agreements from '../../../support/fragments/agreements/agreements';
+import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
 import AgreementLines from '../../../support/fragments/agreements/agreementLines';
-import TopMenu from '../../../support/fragments/topMenu';
-import { DevTeams, TestTypes } from '../../../support/dictionary';
 import AgreementViewDetails from '../../../support/fragments/agreements/agreementViewDetails';
-import SearchAndFilterAgreementLines from '../../../support/fragments/agreements/searchAndFilterAgreementLines';
-import AgreementLineInformation from '../../../support/fragments/agreements/agreementLineInformation';
+import Agreements from '../../../support/fragments/agreements/agreements';
 import DeleteConfirmationModal from '../../../support/fragments/agreements/modals/deleteConfirmationModal';
+import SearchAndFilterAgreementLines from '../../../support/fragments/agreements/searchAndFilterAgreementLines';
+import TopMenu from '../../../support/fragments/topMenu';
 
 let agreementLine;
 let agreementId;
@@ -31,31 +30,25 @@ describe('Agreement Lines', () => {
     Agreements.deleteViaApi(agreementId);
   });
 
-  it(
-    'C405546 Delete Agreement Line (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
-    () => {
-      AgreementViewDetails.openAgreementLineFilter();
-      SearchAndFilterAgreementLines.verifyFilterOptions();
-
-      SearchAndFilterAgreementLines.search(agreementLine.description);
-      AgreementLines.verifyAgreementLinesCount(1);
-
-      AgreementLines.agreementLinesListClick(agreementLine.description);
-      AgreementLineInformation.waitLoadingWithExistingLine(agreementLine.description);
-      AgreementLineInformation.verifyActionsButtons();
-
-      AgreementLineInformation.gotoDelete();
-      DeleteConfirmationModal.waitLoading();
-
-      DeleteConfirmationModal.confirmDeleteAgreementLine();
-      AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(
-        Agreements.defaultAgreement.name,
-      );
-
-      AgreementViewDetails.openAgreementLineFilter();
-      SearchAndFilterAgreementLines.search(agreementLine.description);
-      AgreementLines.verifyAgreementLinesCount(0);
-    },
-  );
+  it('C405546 Delete Agreement Line (erm) (TaaS)', { tags: ['extendedPath', 'erm'] }, () => {
+    AgreementViewDetails.openAgreementLineFilter();
+    SearchAndFilterAgreementLines.verifyFilterOptions();
+
+    SearchAndFilterAgreementLines.search(agreementLine.description);
+    AgreementLines.verifyAgreementLinesCount(1);
+
+    AgreementLines.agreementLinesListClick(agreementLine.description);
+    AgreementLineInformation.waitLoadingWithExistingLine(agreementLine.description);
+    AgreementLineInformation.verifyActionsButtons();
+
+    AgreementLineInformation.gotoDelete();
+    DeleteConfirmationModal.waitLoading();
+
+    DeleteConfirmationModal.confirmDeleteAgreementLine();
+    AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(Agreements.defaultAgreement.name);
+
+    AgreementViewDetails.openAgreementLineFilter();
+    SearchAndFilterAgreementLines.search(agreementLine.description);
+    AgreementLines.verifyAgreementLinesCount(0);
+  });
 });

cypress/e2e/agreements/agreement-lines/view-an-agreement-line.cy.js

@@ -1,8 +1,7 @@
-import Agreements from '../../../support/fragments/agreements/agreements';
-import TopMenu from '../../../support/fragments/topMenu';
-import { TestTypes, DevTeams } from '../../../support/dictionary';
 import AgreementLines from '../../../support/fragments/agreements/agreementLines';
 import AgreementViewDetails from '../../../support/fragments/agreements/agreementViewDetails';
+import Agreements from '../../../support/fragments/agreements/agreements';
+import TopMenu from '../../../support/fragments/topMenu';
 
 let agreementLine;
 let agreementId;
@@ -33,20 +32,14 @@ describe('Agreement Lines', () => {
     Agreements.deleteViaApi(agreementId);
   });
 
-  it(
-    'C761 View an Agreement line (erm) (TaaS)',
-    { tags: [TestTypes.extendedPath, DevTeams.erm] },
-    () => {
-      AgreementViewDetails.agreementListClick(Agreements.defaultAgreement.name);
-      AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(
-        Agreements.defaultAgreement.name,
-      );
-      AgreementViewDetails.verifyAgreementLinesCount('1');
+  it('C761 View an Agreement line (erm) (TaaS)', { tags: ['extendedPath', 'erm'] }, () => {
+    AgreementViewDetails.agreementListClick(Agreements.defaultAgreement.name);
+    AgreementViewDetails.verifyAgreementDetailsIsDisplayedByTitle(Agreements.defaultAgreement.name);
+    AgreementViewDetails.verifyAgreementLinesCount('1');
 
-      AgreementViewDetails.openAgreementLineSection();
-      AgreementViewDetails.verifySpecialAgreementLineRow({
-        description: agreementLine.description,
-      });
-    },
-  );
+    AgreementViewDetails.openAgreementLineSection();
+    AgreementViewDetails.verifySpecialAgreementLineRow({
+      description: agreementLine.description,
+    });
+  });
 });