STCOM-1288: Focus the last modified query field when opening <AdvancedSearch>.
#2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dmytro-Melnyshyn
force-pushed
the
STCOM-1288
branch
from
4080129
to
26ea723
Compare
Dmytro-Melnyshyn
changed the title
<AdvancedSearch>, otherwise on the last query field.<AdvancedSearch>.
Dmytro-Melnyshyn
force-pushed
the
STCOM-1288
branch
from
26ea723
to
ac57283
Compare
Dmytro-Melnyshyn
changed the title
<AdvancedSearch>.<AdvancedSearch>.
BogdanDenis
approved these changes
May 7, 2024
JohnC-80
approved these changes
May 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, after opening the advanced search modal window, the focus was on the first query field.
After this PR is merged, the focus will be on the last modified query field made in the advanced search modal, or, if the previously modified field wasn't a query, the focus will be shifted to the last non-empty query field.
The
isCursorAtEndproperty will place the cursor at the end of the field value.Tests will pass after this PR #2277 is merged.
Related PRs
#2277
Issues
STCOM-1288
Screencast
2024-05-02_22h29_58.mp4