Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-922: Add tabbed interface components #1718

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndrewIsh
Copy link

This commit adds the ability to create tabbed interfaces, it is
dependent on by UITEST-90

This commit adds the ability to create tabbed interfaces, it is
dependent on
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I noted some minor quibbles about arrangement of the components in a single file and the CSS import (tests would not run for me until I changed the variables import), but everything else looks good to me. Nice work!

lib/Tabs/Tabs.css Outdated Show resolved Hide resolved
lib/Tabs/index.js Outdated Show resolved Hide resolved
const tabPanel2 = await TabPanelInteractor('Panel 2');
await tab.click();
await Keyboard.arrowRight();
await tabPanel2.exists();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to assert tabPanel2.exists() === false before arrowClick? I'm new to this code, obvs, but it feels like all the tabs are created in mount so testing exists() feels funny.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand this. Are you saying I should test that tabPanel2 doesn't exist before the arrowRight() that causes it to exist happens? If so, I agree! But I thought I should check before I did it. Thanks!

This commit responds to the first two points made by @zburke in the PR
feedback:

- Change CSS import to use local path
- Split into separate components
@JohnC-80
Copy link
Contributor

We're going to have to move this to a non-fork branch to get CI to ultimately pass. Sonarcloud doesn't seem to want to run on forks.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 5d9a980. ± Comparison against base commit 27fefff.

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

BigTest Unit Test Statistics

0 files   -        1  0 suites   - 1   0s ⏱️ -3s
0 tests  - 1 210  0 ✔️  - 1 205  0 💤  - 5  0 ±0 
0 runs   - 1 212  0 ✔️  - 1 207  0 💤  - 5  0 ±0 

Results for commit 5d9a980. ± Comparison against base commit 27fefff.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Andrew Isherwood seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JohnC-80 JohnC-80 marked this pull request as draft January 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants