Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCOM-827 Pagination Component #1543

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

JohnC-80
Copy link
Contributor

Add pagination component.

Filling a gap in our current component offerings. Most grids within FOLIO rely on infinite scroll or some other means - but doesn't hurt to have another option to fulfill app requirements.

image

@folio-org folio-org deleted a comment from id-jenkins Apr 16, 2021
Copy link
Contributor

@mkuklis mkuklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @JohnC-80 👏

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2021

Co-authored-by: Viktor Soroka <viktor_soroka@epam.com>
@BogdanDenis
Copy link
Contributor

Looks great! We're thinking of applying this component in eHoldings app, is there something that's blocking this PR from being merged?

@github-actions
Copy link

github-actions bot commented Sep 13, 2021

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a46bbb9. ± Comparison against base commit 25ec9e1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 13, 2021

BigTest Unit Test Statistics

       1 files  ±0         1 suites  ±0   5s ⏱️ ±0s
1 302 tests +6  1 296 ✔️ +6  6 💤 ±0  0 ±0 
1 305 runs  +6  1 299 ✔️ +6  6 💤 ±0  0 ±0 

Results for commit a46bbb9. ± Comparison against base commit 25ec9e1.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@zburke
Copy link
Member

zburke commented Jan 7, 2022

@JohnC-80, this PR has been hanging out for a while. Can we either merge it, close it, or move it to draft?

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JohnC-80 JohnC-80 marked this pull request as draft January 23, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants