Remove use of alias #276
Merged
Remove use of alias #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandberger
requested review from
mkuklis,
zburke,
MikeTaylor,
skomorokh and
JohnC-80
|
Kudos, SonarCloud Quality Gate passed!
|
skomorokh
approved these changes
Jan 25, 2022
mkuklis
approved these changes
Jan 25, 2022
MikeTaylor
approved these changes
Jan 25, 2022
| @@ -1,6 +1,6 @@ | |||
| # Stripes CLI Commands | |||
|
|
|||
| Version 1.20.0 | |||
| Version 2.5.0 | |||
Yes, seems appropriate to remove with a major release, though I'd want to determine a path for someone to manually remove global aliases when the command no longer exists. |
zburke
reviewed
Jan 31, 2022
Comment on lines
+220
to
221
| Note that in order for local code repositories to be used for a reference made in another module or platform `package.json` file, the local code repository version must fall in the requested version range. Otherwise, `yarn` will fetch from the remote repository instead. | ||
|
|
There was a problem hiding this comment.
This is an especially helpful note. Thanks for adding it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aliascommand and updated documentation in favor ofworkspacealiaswas deprecated in the description and that an upcoming release ofyargsshould provide support that our documentation generator can leverage. See [Question] How do I mark a command as deprecated? yargs/yargs#2115 for details.