RMB-965: runSqlFile with failed Future on SQL failure #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing PostgresClient#runSQLFile methods return a succeeded Future when an SQL statement fails. The database failure messages are returned as a List of String. This doesn't comply with the Future contract. Add a PostgresClient#runSqlFile(String sqlFile) method that returns a failed Future when an SQL statement fails.
steveellis
reviewed
Mar 29, 2023
| asyncResultHandler.handle(io.vertx.core.Future.failedFuture(e.getMessage())); | ||
| log.error("{}", e.getMessage(), e); | ||
| asyncResultHandler.handle(Future.succeededFuture( | ||
| PostAdminImportSQLResponse.respond500WithTextPlain(e.getMessage()))); |
There was a problem hiding this comment.
I agree what you have here uses futures the right way. Also, it looks like this isn't a breaking change to modules that rely on this method. Do I have that right?
steveellis
approved these changes
Apr 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing PostgresClient#runSQLFile methods return a succeeded Future when an SQL statement fails. The database failure messages are returned as a List of String.
This doesn't comply with the Future contract.
Add a PostgresClient#runSqlFile(String sqlFile) method that returns a failed Future when an SQL statement fails.
This simplifies code including RMB production and test code.