STRIPES-677: Lock the version of moment because of its latest release #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorSoroka07
requested review from
zburke,
doytch,
funkymalc,
JohnC-80 and
mkuklis
zburke
approved these changes
May 1, 2020
|
I added this resolution directly to the snapshot branch separately. Closing. |
|
The issue is already fixed by momentjs. @funkymalc, the resolution is no longer needed. Please remove it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Built UI with fresh changes and got a Critical dependency: the request of a dependency is an expression error because of the moment in the browser because of new moment version release. There is an issue filed already in moment repo. Locking the versions on the platform level should fix the issue.