Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump follow-redirects from 1.15.3 to 1.15.4 #2600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jan 11, 2024

Bumps follow-redirects from 1.15.3 to 1.15.4.

Commits
  • 6585820 Release version 1.15.4 of the npm package.
  • 7a6567e Disallow bracketed hostnames.
  • 05629af Prefer native URL instead of deprecated url.parse.
  • 1cba8e8 Prefer native URL instead of legacy url.resolve.
  • 72bc2a4 Simplify _processResponse error handling.
  • 3d42aec Add bracket tests.
  • bcbb096 Do not directly set Error properties.
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.3 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.3...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 11, 2024
zburke
zburke previously approved these changes Jan 11, 2024
@zburke
Copy link
Member

zburke commented Jan 11, 2024

Hmmm, I sort of see why this build is failing: stripes-cli is pulling in stripes-webpack and we're hitting STRWEB-105, so we need to patch versions of stripes-webpack (5.0.2) and stripes-cli (3.0.1) to resolve this. At the same time, don't understand why favicons is getting bumped to 7.1.5 here, because master is a release branch so we should be building from an existing yarn.lock file :/

PS: Ooooooh, 2600. Auspicious! ☎️

@zburke
Copy link
Member

zburke commented Jan 11, 2024

Ah, master isn't considered a "release" branch from the point of view of buildStripesPlatform.groovy. This means yarn.lock is being rebuilt from scratch, allowing favicons 7.1.5 to sneak in.

IMO, if the install repo is npm-folio, we need to preserve an existing yarn.lock. If the install repo is npm-folioci, yarn.lock should be removed so it can be constructed from scratch.

@zburke
Copy link
Member

zburke commented Jan 12, 2024

Patch releases of stripes-webpack and stripes-cli have been made and the checks in this PR re-run; they now pass. We still have the problem that yarn.lock is being rebuild from scratch, but that's how it's always been, so probably it's not a problem we need to solve here.

Copy link
Author

dependabot bot commented on behalf of github Mar 16, 2024

A newer version of follow-redirects exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
2 participants