[QG Part 3] RANCHER-1247 folioCiQualityGates failing during parallel env provisioning #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OHaimanov
requested review from
renatsafiulin,
eldiiar-duishenaliev,
DmytrMoroz,
aatoyan and
epam-avramenko
OHaimanov
changed the title
| //TODO switch to regular job before merge | ||
| String createNamespaceFromBranchJob = '/folioRancher/tmpFolderForDraftPipelines/createNamespaceFromBranch-1247' | ||
| //TODO switch to regular job before merge | ||
| String deleteNamespaceJob = '/folioRancher/tmpFolderForDraftPipelines/deleteNamespace-1247' |
There was a problem hiding this comment.
Are we considering moving pipeline paths (maybe to Constants) so they aren't written as strings in dependent pipelines?
Maybe some class or module to work with dependent pipelines.
There was a problem hiding this comment.
yeap, we have, it will be separate PR
| string(name: 'S3_BUCKET', value: namespaceCreateParams.getS3Type()), | ||
| string(name: 'MEMBERS', value: namespaceCreateParams.getMembers()), | ||
| string(name: 'AGENT', value: namespaceCreateParams.getWorker())] | ||
| logger.debug(jobResult.dump()) |
There was a problem hiding this comment.
If there is some class or module where values will be cloned for invoked pipelines, we will remove a bunch of boilerplate code and the pipeline itself will be easier to read. Since we are transitioning towards re-invoked pipelines, it becomes important to unify their invocation.
There was a problem hiding this comment.
I think we could discuss this option and create ticket for improvement
epam-avramenko
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://folio-org.atlassian.net/browse/RANCHER-1247