[QG Part 2] RANCHER-1001 Integrate Karate Tests Flow with folioCiQualityGates Jenkins Pipeline #442
Conversation
OHaimanov
requested review from
renatsafiulin,
eldiiar-duishenaliev,
DmytrMoroz,
aatoyan and
epam-avramenko
OHaimanov
force-pushed
the
RANCHER-1002
branch
from
afecc40
to
7f12f37
Compare
OHaimanov
force-pushed
the
RANCHER-1001
branch
from
ccac791
to
dd64cf5
Compare
| limits: | ||
| memory: 10240Mi |
There was a problem hiding this comment.
in one of our commits, there was a variable implementation for specifying desired amount of RAM for PSQL STS, why do we skip it?
There was a problem hiding this comment.
If I am not mistake, implemented ROM variable for storage, not for RAM
| @@ -128,17 +150,32 @@ ansiColor('xterm') { | |||
| ] | |||
| folioCypressFlow(cypressParams) | |||
| } | |||
| branches['Karate'] = { -> | |||
There was a problem hiding this comment.
this requires okapi to be in cluster mode, I guess...
There was a problem hiding this comment.
It's separate thing, not included in this scope
| parallel(branches) | ||
|
|
||
| // Map branches = [failFast: false] | ||
| // namespacesMap.each { id, namespace -> |
There was a problem hiding this comment.
Why do we keep this huge commented block?
There was a problem hiding this comment.
It will be removed in next PR's
| //@Library('pipelines-shared-library@RANCHER-741-Jenkins-Enhancements') _ | ||
| @Library('pipelines-shared-library@RANCHER-1002') _ | ||
| @Library('pipelines-shared-library@RANCHER-1001') _ |
There was a problem hiding this comment.
Just for current testing, will be changed during final merge
| end_of_line = lf | ||
| charset = utf-8 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
|
|
||
| [*.{java,scala,gradle,proto,groovy}] | ||
| indent_style = space | ||
| indent_size = 2 |
There was a problem hiding this comment.
this config file changing too often :)
| parallel(branches) | ||
| } | ||
| } catch (e) { | ||
| logger.error "Caught exception: ${e}" | ||
| error(e.getMessage()) | ||
| } finally { | ||
| input 'Paused' |
There was a problem hiding this comment.
Will be removed in final merge
| @@ -27,7 +27,7 @@ resource "rancher2_app_v2" "kafka" { | |||
| enabled: true | |||
| resources: | |||
| limits: | |||
| memory: 512Mi | |||
| memory: 1280Mi | |||
There was a problem hiding this comment.
the same as PSQL var implementation, just skipped :(
Jira: https://folio-org.atlassian.net/browse/RANCHER-1001