[QG Part 1] RANCHER-1002 Integrate Cypress Tests Flow with Jira Ticketing and Slack Notifications in folioCiQualityGates Jenkins Pipeline #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OHaimanov
requested review from
renatsafiulin,
eldiiar-duishenaliev,
DmytrMoroz,
aatoyan and
epam-avramenko
OHaimanov
force-pushed
the
RANCHER-1002
branch
from
c1760e1
to
1a49c5a
Compare
aatoyan
approved these changes
Feb 19, 2024
eldiiar-duishenaliev
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Hello Sasha,
In overall looks outstanding!
But, some changes could potentially break existing workflows.
As an example another PR created and pending review for a 100% will be conflicting.
Not a big deal to correct kubectl part on it, but please let's avoid existing libs modification, instead, we could implement versioning, something like:
checkNsExistence
checkNsExistencev2 and so on, what do you think?
Thanks again, quite huge changes and approach switch, which is AWSome :)
OHaimanov
force-pushed
the
RANCHER-1002
branch
5 times, most recently
from
8921478
to
afecc40
Compare
OHaimanov
changed the base branch from
RANCHER-741-Jenkins-Enhancements
to
RANCHER-1054
OHaimanov
changed the title
OHaimanov
force-pushed
the
RANCHER-1054
branch
from
33473a8
to
418795f
Compare
OHaimanov
force-pushed
the
RANCHER-1002
branch
from
afecc40
to
7f12f37
Compare
…ck Notifications in folioCiQualityGates Jenkins Pipeline Jira: https://folio-org.atlassian.net/browse/RANCHER-1002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://folio-org.atlassian.net/browse/RANCHER-1002