MODSOURMAN-1127 LCCN normalization for MARC authority: change mappings for 010 field #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change MARC Authority mapping rule - Update NEWS.md Closes MODSOURMAN-1127
- Add test for updated mapping rule Closes MODSOURMAN-1127
- Add custom migration class Closes MODSOURMAN-1127
- Add tests for custom migration class Closes MODSOURMAN-1127
viacheslavpoliakov
changed the title
viacheslavpoliakov
changed the title
- Clean code Closes MODSOURMAN-1127
- Add force update for MARC Authority validation Closes MODSOURMAN-1127
# Conflicts: # NEWS.md
- Improve logic - Fix error Closes MODSOURMAN-1127
- Fix test Closes MODSOURMAN-1127
- Removed logic Closes MODSOURMAN-1127
- Removed logic Closes MODSOURMAN-1127
- Create mapping helper for 010 field Closes MODSOURMAN-1127
- Fixe Sonar duplication warnings Closes MODSOURMAN-1127
- Fixe Sonar issues Closes MODSOURMAN-1127
# Conflicts: # NEWS.md
- Clean code Closes MODSOURMAN-1127
- Clean imports Closes MODSOURMAN-1127
viacheslavpoliakov
requested review from
psmagin,
TsaghikKhachatryan,
viacheslavkol and
mukhiddin-yusuf
.../src/main/java/org/folio/services/migration/impl/AuthorityMapping010LccnCustomMigration.java
Outdated
Show resolved
Hide resolved
psmagin
reviewed
Apr 26, 2024
...ord-manager-server/src/main/java/org/folio/services/migration/helper/FieldMappingHelper.java
Outdated
Show resolved
Hide resolved
- Move entity creation logic to migration class Closes MODSOURMAN-1127
psmagin
approved these changes
Apr 27, 2024
viacheslavkol
approved these changes
Apr 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
MODSOURMAN-1127 Separate 010$a and 010$z subfield mapping as "LCCN" for $a and "Canceled LCCN" for $z
Approach
Change mapping rule
Create migration class
Is this change testable? If not - why?
Checklist