Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working on users #248

Closed
wants to merge 3 commits into from
Closed

Working on users #248

wants to merge 3 commits into from

Conversation

kjain110
Copy link
Contributor

Purpose

Describe the purpose of the pull request. Include background information if necessary.

Approach

How does this change fulfill the purpose?

TODOS and Open Questions

  • Use GitHub checklists. When solved, check the box and explain the answer.

Learning

Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.

Pre-Merge Checklist

If you are adding entity type(s), have you:

  • Added the JSON5 definition to the src/main/resources/entity-types directory?
  • Ensured that GETing the entity type at /entity-types/{id} works as expected?
  • Added translations for all fields, per the translation guidelines? (Check this by ensuring GET /entity-types/{id} does not have mod-fqm-manager.entityType. in the response)
  • Added views to liquibase, as applicable?
  • Added required interfaces to the module descriptor?
  • Checked that querying fields works correctly and all SQL is valid?

@kjain110 kjain110 changed the base branch from master to poc April 25, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants