Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platform-complete stripes building issue fix addition to previous tic… #153

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

platform-complete stripes building issue fix addition to previous tic… #153

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18a0061
platform-complete stripes building issue fix addition to previous tic…
eldiiar-duishenaliev Jan 4, 2024
854135d
adjusted according to Zak's suggestions & addition to previous ticket…
eldiiar-duishenaliev Jan 12, 2024
f70a361
adjusted according to Zak's suggestions & addition to previous ticket…
eldiiar-duishenaliev Jan 16, 2024
b1f5f5f
adjusted according to Zak's suggestions & addition to previous ticket…
eldiiar-duishenaliev Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions vars/buildStripesPlatform.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ def call(String okapiUrl, String tenant, String branch='') {

def foliociLib = new org.folio.foliociCommands()

if (!(branch =~ /^(r|R)\d{1}-\d{4}(-(rc|RC|hotfix-\d{1}))?$/)) {
if (!(branch =~ /^[rR]\d-\d{4}(-([rR][cC]|hotfix-\d))?/)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the trailing $ enables branches like R2-2023-Consortia, but is a lot more broad than that, too. Do we want to be that broad?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using branches named like 2023-R2... instead of R2... that do not sort correctly. Is this an opportunity to correct that gaffe or has that ship already sailed?

sh 'rm -f yarn.lock'
}

sh 'yarn install'
sh 'yarn install --frozen-lockfile'

// publish generated yarn.lock for possible debugging
sh 'mkdir -p ci'
Expand Down