allow store to use http query params in requests #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
om26er
force-pushed
the
store-allow-query-params
branch
from
178f22c
to
861e993
Compare
|
@folbricht what do you think about this ? |
|
This basically preserves any query parameters given in the store URL (for HTTP stores and index stores). This seems safe to do. Would you be able to add a section in the README.md describing how to use signed URLs with a simple example? |
|
Sure, I will add something during the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chunk store does not pass http query params when downloading chunks, this means if a URL is protected desync won't be able to download and hence fail. This PR fixes that and I have verified the change actually does work with Cloudfront's presigned URLs