Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: globally installs codecov as part of CI pipeline #296

Merged
merged 1 commit into from Mar 6, 2021

Conversation

thawkin3
Copy link
Contributor

@thawkin3 thawkin3 commented Mar 6, 2021

I've updated our usage of codecov to no longer be a devDependency and instead be installed globally as part of the GitHub Actions workflow in the CI pipeline.

This follows the same pattern found in the tabbable repo here: focus-trap/tabbable#261

PR Checklist

Please leave this checklist in your PR.

  • Issue being fixed is referenced.
  • Source changes maintain:
    • Stated browser compatibility.
    • Stated React compatibility.
  • Unit test coverage added/updated.
  • E2E test coverage added/updated.
  • Prop-types added/updated.
  • Typings added/updated.
  • README updated (API changes, instructions, etc.).
  • Changes to dependencies explained.
  • Changeset added (run yarn changeset locally to add one, and follow the prompts).
    • EXCEPTION: A Changeset is not required if the change does not affect any of the source files that produce the package bundle. For example, tooling changes, test updates, or a new dev-only dependency to run tests more efficiently should not have a Changeset since it will not affect package consumers.

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2021

⚠️ No Changeset found

Latest commit: d9c39cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #296 (5f53992) into master (d802cb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #296   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files           1        1           
  Lines          72       72           
  Branches       27       27           
=======================================
  Hits           70       70           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d802cb8...d9c39cc. Read the comment docs.

@thawkin3
Copy link
Contributor Author

thawkin3 commented Mar 6, 2021

@stefcameron @maraisr Here are those same Codecov changes that I made over in the tabbable repo (focus-trap/tabbable#261) whenever you have a minute to review.

Copy link
Contributor

@maraisr maraisr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow—awesome mate. 🤙🏼

@maraisr maraisr merged commit 038a727 into focus-trap:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants