Change reading file from native fs to vscode alternative

[pderaaij]

This PR changes the lasst occurence of reading files natively from fs. This is required for using Foam on the web version of vscode, but also follows best practices.

[riccardoferretti]

Thanks for pulling out this change, I believe it's great to have the code itself ready for the transition, so that the rest is just a matter of build and testing.

I have a question about the approach though, see my comment in the diff.

[riccardoferretti]

Are you sure this will work?
I am not sure this would work, as this call returns a promise, and whether noteText is actually set when needed (e.g. line 192) becomes a matter of timing.
This is the reason why originally we didn't migrate this part of the code from readFileSync.

Am I missing something?

[pderaaij]

It is not working. Need to refine it, but needed a test run on thr CI as I had some issues locally. Forgot to add wip to the PR ;)

[pderaaij]

I am not sure how we can get this working. markdown-it is synchronous by design. On that same note, vascode is asynchronous intentional. Two things that doesn't work well together. I am not sure how to continue. The only hunch I have is to change its implementation from a regex replace to a custom renderer. But that would require quite some research.

Any ideas moving forward are welcome. This is a blocking issue to get Foam working properly on the web (#749).

[riccardoferretti]

Yup, that limitation of markdown-it is quite something. Here are some thoughts I had about working around it, let me know what you think: #1116 (comment)