This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add build-tool cli with a crd validation command #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
reviewed
Sep 25, 2019
Gopkg.toml
Outdated
| @@ -85,6 +86,10 @@ required = [ | |||
| # revision = "6702109cc68eb6fe6350b83e14407c8d7309fd1a" | |||
| version = "kubernetes-1.13.5" | |||
|
|
|||
| [[override]] | |||
| name = "k8s.io/kube-openapi" | |||
| revision = "743ec37842bffe49dd4221d9026f30fb1d5adbc4" | |||
There was a problem hiding this comment.
Do they not have versions?
Gopkg.toml
Outdated
|
|
||
| [[constraint]] | ||
| name = "github.com/kubeflow/crd-validation" | ||
| source = "github.com/bnsblue/crd-validation.git" |
There was a problem hiding this comment.
Let's try to get this forked under lyft... if that proved to be too hard, then this is ok we can switch it later.
There was a problem hiding this comment.
Sure. I am waiting on the fork request to be approved...
| return err | ||
| } | ||
|
|
||
| compilerErrors.SetIncludeSource() |
| err := c.initConfig() | ||
| var generator *crd.FlyteWorkflowGenerator | ||
| if err != nil { | ||
| log.Println("Output will be written to Stdout") |
There was a problem hiding this comment.
Any reason you don't just fail here instead of trying to "recover" ?
cmd/build-tool/main.go
Outdated
| fmt.Println(err) | ||
| os.Exit(1) | ||
| } | ||
| } |
Add a new line at the end of the file Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>
Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>
Co-Authored-By: Haytham AbuelFutuh <habuelfutuh@lyft.com>
|
ping @bnsblue, do we want to move ahead with this? |
|
@kumare3 Yes we do. I'll take some time to merge this during the next week |
8 tasks
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
* add namepace configuration * add namespace files * remove unused var * update propeller executor config * use propeller executor configuration * to lowercase * fix conflicts * update namespace test * remove namespaceMapping variable * fix compile issues * add project-domain option and remove incorrect log messages * upd mock configuration provider * update unit tests * Merge logs on task execution event updates (flyteorg#18) * use fallthrough * Correct Lint Errors and Add Documentation on Pre-Commit (flyteorg#19) * README update * Fix lint errors * add namepace configuration * add namespace files * remove unused var * update propeller executor config * use propeller executor configuration * to lowercase * fix conflicts * update namespace test * remove namespaceMapping variable * fix compile issues * add project-domain option and remove incorrect log messages * upd mock configuration provider * update unit tests * use fallthrough * fix conflicts * fix more conflicts * lint * remove duplicate package * fix lint errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of crd validation as a command in a new CLI in flytepropeller