Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Support API Key for authentication #384

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Support API Key for authentication #384

wants to merge 3 commits into from

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Mar 28, 2023

Read then delete this section

- Make sure to use a concise title for the pull-request.

- Use #patch, #minor or #major in the pull-request title to bump the corresponding version. Otherwise, the patch version
will be bumped. More details

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #384 (f2d7fd4) into master (bdb7630) will increase coverage by 1.27%.
Report is 25 commits behind head on master.
The diff coverage is 56.66%.

❗ Current head f2d7fd4 differs from pull request most recent head 71406e7. Consider uploading reports for the commit 71406e7 to get more accurate results

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   76.71%   77.99%   +1.27%     
==========================================
  Files          18       19       +1     
  Lines        1426     1268     -158     
==========================================
- Hits         1094      989     -105     
+ Misses        280      224      -56     
- Partials       52       55       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
clients/go/admin/config.go 50.00% <ø> (ø)
clients/go/admin/token_source_provider.go 56.41% <47.82%> (-2.42%) ⬇️
clients/go/admin/api_key.go 85.71% <85.71%> (ø)

... and 16 files with indirect coverage changes

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Copy link
Contributor

@wild-endeavor wild-endeavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but let me know when you want a real review

Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants