Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display failure node in workflow graph #845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lyonlu13
Copy link

@lyonlu13 lyonlu13 commented Feb 23, 2024

What changes were proposed in this pull request?

Display failure node in workflow graph, including failure workflow.
image
image

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Modified parseWorkflow function to parse failure nodes. To avoid excessive changes, use the same construction method as much as possible. Node annotations or styles could be added in the future according to needs (Might need additional property).

Tracking Issue

NA

Follow-up issue

NA

Signed-off-by: Lyon Lu <lyonlu13@gmail.com>
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.16%. Comparing base (a162fb0) to head (f89be26).

Files Patch % Lines
...ponents/WorkflowGraph/transformerWorkflowToDag.tsx 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   63.17%   63.16%   -0.02%     
==========================================
  Files         528      528              
  Lines       13449    13455       +6     
  Branches     2567     2569       +2     
==========================================
+ Hits         8497     8499       +2     
- Misses       4952     4956       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant