Check existence of $HELM_HOME/plugins before installing plugin

Fixes helm#2488
flynnduism · May 28, 2017 · ef1b297 · ef1b297
1 parent 0fad699
commit ef1b297
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/pkg/plugin/installer/installer.go b/pkg/plugin/installer/installer.go
@@ -19,6 +19,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"path"
 	"path/filepath"
 
 	"k8s.io/helm/pkg/helm/helmpath"
@@ -42,6 +43,10 @@ type Installer interface {
 
 // Install installs a plugin to $HELM_HOME.
 func Install(i Installer) error {
+	if _, pathErr := os.Stat(path.Dir(i.Path())); os.IsNotExist(pathErr) {
+		return errors.New(`plugin home "$HELM_HOME/plugins" does not exists`)
+	}
+
 	if _, pathErr := os.Stat(i.Path()); !os.IsNotExist(pathErr) {
 		return errors.New("plugin already exists")
 	}