Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Implementation of User Listening History Download #447

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

CosmicSage
Copy link

I successfully add listening history download to scdl. In many of my attempts to download I have always got the desired result .

My Code is very non-invasive to the codebase almost like blue in sky, as you might expect.

Ok so the test may fail because @7x11x13 of soundcloud.py API wrapper hasn't yet merged my work of adding history endpoint to the wrapper whose PR you can see here

So to test on your computer you can check my fork and copy paste two files to your site-packages (that's what I did in development)

Look if this gets merged I will make it cleaner and enhance this new feature as well, as the api returns few more data fields which are not considered while downloading.

Hope you like it. Please merge fast

Thank you

@CosmicSage
Copy link
Author

Here's the screenshot of results
Screenshot (470)

You must copy the main soundcloud.py and resource/history.py from soundcloud api wrapper fork to site-packages to test this locally as @7x11x13 hasn't merged/released my code yet/

@7x11x13 @flyingrub

@CosmicSage
Copy link
Author

Also can I get mordertor access I will take care I swear..🙏 @7x11x13 @flyingrub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant