New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bashate support #1866
base: master
Are you sure you want to change the base?
Add bashate support #1866
Conversation
11a6173
to
6f6ed3a
Compare
Hello, can I have some help here? |
@cpitclaudel Can you please help me here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I'm not a maintainer but tried to take a look anyway. Fundamentally everything works (I've confirmed it doesn't activate for sh
and that the ignore list works), but there are just some minor things that need updating.
flycheck-option-comma-separated-list) | ||
source) | ||
:error-patterns | ||
; bash8 follows pycodestyle/pep8 default output format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most minor of nits: indent and use ;;
for consistency with the rest of the file.
:error-patterns | ||
; bash8 follows pycodestyle/pep8 default output format | ||
; https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L108 | ||
((error line-start (file-name) ":" line ":1: " (message) line-end)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this was weird, but lo and behold, there it is:
$ rg -F ':1:'
bashate/bashate.py
300: print("%(filename)s:%(filelineno)s:1: %(error)s" %
source) | ||
:error-patterns | ||
; bash8 follows pycodestyle/pep8 default output format | ||
; https://github.com/PyCQA/pycodestyle/blob/master/pycodestyle.py#L108 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is out of date. Can you update it and use a link with a fixed hash? You can press y
once you've selected the line in the file on GitHub and the URL will magically change.
See URL `https://docs.openstack.org/bashate/latest/'." | ||
:command ("bashate" | ||
(option "--ignore" flycheck-bashate-excluded-warnings list | ||
flycheck-option-comma-separated-list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on adding max line length?
--max-line-length MAX_LINE_LENGTH
Max line length
Fixes #1865
Please have a closer look at this code. I've got next to none elisp experience.