fix(a380x): Correct flap/slats positions #8651
Open
+650
−253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
added
Not Ready For Testing
flogross89
force-pushed
the
fix-a380x-flaps-positions
branch
3 times, most recently
from
9064aa9
to
9c59c77
Compare
flogross89
removed
Not Ready For Testing
tracernz
requested changes
May 15, 2024
fbw-common/src/wasm/systems/systems/src/simulation/update_context.rs
Outdated
Show resolved
Hide resolved
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🔴 Code Review: In progress
May 15, 2024
(cherry picked from commit bf94a44)
flogross89
force-pushed
the
fix-a380x-flaps-positions
branch
from
826f3be
to
5877d39
Compare
|
@tracernz Reworked some bits, your comments should now be addressed |
tracernz
reviewed
May 26, 2024
| @@ -210,7 +211,7 @@ impl SlatFlapControlComputer { | |||
| if context.is_in_flight() | |||
| && (context.indicated_airspeed().get::<knot>() | |||
| < Self::ALPHA_SPEED_LOCK_IN_AIRSPEED_THRESHOLD_KNOTS | |||
| || context.angle_of_attack().get::<degree>() | |||
| || adirs_output.angle_of_attack(1).value().get::<degree>() | |||
There was a problem hiding this comment.
You should check the SSM before using the value. Should it just blindly always use ADR1, or should there be some selection logic to choose an ADR based on validity of the data/SSM?
| fn set_angle_of_attack(&mut self, v: Angle) { | ||
| self.angle_of_attack = Arinc429Word::new(v, SignStatus::NormalOperation); | ||
| } | ||
| } |
There was a problem hiding this comment.
This feels very weird. Don't we already have the stuff to mock the ADR in the test bed? @Gurgel100 will know better than me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A380X only, no QA needed.
Summary of Changes
This should be an improvement to the current SFCC implementation for the A380X.
In scope:
Out of scope:
Screenshots (if necessary)
References
Additional context
No appropriate references for A380 FPPU, hence it's assumed the same FPPU as in the A320 is used.
Resulting FPPU angles:
Discord username (if different from GitHub): floridude
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.