fix(a380x): PFD lint, PFD speed tape Vfe, Vmo, Mmo, Vle #8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flogross89
added
Do Not Merge
QA A380 Only
2hwk
approved these changes
May 9, 2024
Quality Assurance
automation
moved this from 🟡 Code Review: Ready for Review
to 🟣 QA Team Review: Ready to Test
May 9, 2024
2hwk
approved these changes
May 9, 2024
| @@ -1906,14 +1906,14 @@ FacComputer::Parameters_FacComputer_T FacComputer::FacComputer_P{ | |||
| { 0.0, 1.0, 2.0, 3.0, 4.0, 5.0 }, | |||
| 1.23, | |||
|
|
|||
| { 230.0, 200.0, 200.0, 185.0, 177.0, 177.0 }, | |||
| { 263.0, 220.0, 220.0, 196.0, 182.0, 182.0 }, | |||
There was a problem hiding this comment.
Suggested change
| { 263.0, 220.0, 220.0, 196.0, 182.0, 182.0 }, | |
| { 263.0, 220.0, 220.0, 196.0, 182.0, 182.0 }, |
Are these changed in the simulink models too?
There was a problem hiding this comment.
Unfortunately no, I don't have Simulink and the files are in a binary format. Do you know someone who could update them? Should be fairly quick
There was a problem hiding this comment.
@lukecologne Could take a look at this at some point if/when he's available.
Quality Assurance
automation
moved this from 🟣 QA Team Review: Ready to Test
to ✔️ Done
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A380X only, no QA needed.
Summary of Changes
Screenshots (if necessary)
n/a
References
FCOM, YouTube videos
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.